Help in deleting no right mouse click code from 10k of pages on server

[swedguy]

I just went through the Perl 5.8 Changelog (I tried the script on 5.6) and nothing interesting in there. Thought they might've changed something.

If you just try this little script

PHP Code:

#!/usr/bin/perl

$var = 'hello';
print $var; 


Does it work?

[Cleo]

I'm getting this error

myscripts/remove-right-mouse-code.pl: undef: command not found
myscripts/remove-right-mouse-code.pl: line 5: syntax error near unexpected token `s/(/<'
myscripts/remove-right-mouse-code.pl: line 5: `s/(/<script language="JavaScript1\.2">.*?document\.captureEvents\(Event\.MOUSEUP\).*?document\.captureEvents\(Event.MOUSEDOWN\).*?<\/script>)//

I have my scripts in a non public directory so I can't do a link but here is a copy and paste from it.
#!/usr/bin/perl -pi

undef $/;
s/<script language="JavaScript1\.2">.*?document\.captureEvents\(Event\.MOUSEUP\).*?document\.captureEvents\(Event.MOUSEDOWN\).*?<\/script>//sm;

[Cleo]

$ myscripts/test.pl
hello
$

[swedguy]

Hmm, something is wrong here.

Originally posted by Cleo
myscripts/remove-right-mouse-code.pl: line 5: syntax error near unexpected token `s/(/<'
myscripts/remove-right-mouse-code.pl: line 5: `s/(/<script language="JavaScript1\.2">.*?document\.captureEvents\(Event\.MOUSEUP\).*?document\.captureEvents\(Event.MOUSEDOWN\).*?<\/script>)//

Originally posted by Cleo

#!/usr/bin/perl -pi

undef $/;
s/<script language="JavaScript1\.2">.*?document\.captureEvents\(Event\.MOUSEUP\).*?document\.captureEvents\(Event.MOUSEDOWN\).*?<\/script>//sm;

The remove-right-mouse-code.pl script is not the same as the one that produced the error. The error comes from the old code.

[swedguy]

I could sort of reproduce the error in two ways.

1. Don't have a #!/usr/bin/perl -pi as the first line.

2. Have a space before #!/usr/bin/perl -pi

[Cleo]

I took at the empty lines in the script and got this error.

Unmatched ( in regex; marked by <-- HERE in m/( <-- HERE / at myscripts/remove-right-mouse-code.pl line 3.

[airdick]

I'm betting on a blank first line..

ooopss. i was a little slow on the reply. Now all that's left is the perl debugging.

[swedguy]

Originally posted by Cleo
I took at the empty lines in the script and got this error.

Unmatched ( in regex; marked by <-- HERE in m/( <-- HERE / at myscripts/remove-right-mouse-code.pl line 3.

Awsome, then the problem was an empty line and you are still using the old code

It's probably stuck in your cache. Here's a new url for you: http://www.sponsororganizer.com/FreeScripts/cleo2.html

And remember, no empty lines in the beginning

[Cleo]

We Have Liftoff!

No errors in telnet and when I run top I see find running.

There is 7 gigs in there so I guess this will take awhile.

[swedguy]

[venturi]

Wow! This thread turned into a Perl workshop overnight!

Cool stuff SwedeGuy.

[Cleo]

This has turned into a very interesting thread.

I really wish I knew more about this stuff. I know just enough to be somewhat dangerous. LOL

I already checked some pages and the script is working very well.

The directories and files are still full of spaces but it isn't that big of a deal.

[Entreri]

Here are my 2 cents on this thread...

1. Be sure to backup your stuff - unless you have absolute faith - before running a search-and-replace script. If you cancel the script while it is working, you might wreck one file. (Plus, without any logging or output, you cannot know which file may be messed-up)

2. The script obviously cannot strip what it doesn't know. Therefore, where you wrote the right-clicking script differently, it won't strip it. Sure, one could make the regular expression a bit more flexible but it's troubles that could be avoided.

Here are two suggestions to avoid those problems in the future :

1. If you gotta use Javascript, you might consider using *one* centralized included javascript. In our situation, you could have modified the javascript in question at will or it would make a single line to search-and-strip in all your files.

Ex.

<SCRIPT language=javascript src=http://blah/blockrightclick.js></SCRIPT>

2. Or, you could add comments that act as tags around code to clearly identify those blocks.

<!-- RightClickStart  --> 
<script>

my script to block right-click here 

</script>
<!-- RightClickEnd  -->

Then, if you think one of the files does not use the same block of code, or you want to modify the block of code, or remove it altogether, those tags make it very easy to do so.

Entreri.

[Cleo]

Yeah I made a tarball of the whole site before running this just incase something went horribly wrong.

As for the code I would never do something like this. This whole site was done in FrontPage with the server extensions by someone that had no idea what they were doing over 6 years.

I've looked through many of the pages and have yet to find any pages with this code still in them so it looks like this worked extremely well.

[Rorschach]

*cough*

man sed